Add messages with key to test_communication #542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
2eaefd2 to
ee107f2
Compare
fujitatomoya
requested changes
Sep 19, 2024
Comment on lines
+44
to
+45
| string_ends_with("${interface_file}" ".idl" is_idl) | ||
| if(is_idl AND interface_ns STREQUAL "msg") |
Contributor
There was a problem hiding this comment.
Is this bug, that is unrelated to this original fix? .idl files are included in messages.
Contributor
Author
There was a problem hiding this comment.
In a way, yes.
ros2/rcl_interfaces#162 uncovered a bug in this CMakeLists.txt file.
The code here is not considering the case where a message is directly defined in a .idl file.
I suppose I could make a separate PR with the changes in 486acce.
Contributor
There was a problem hiding this comment.
I guess we can fix this with another PR, so that we can backport this fix to other distros.
Contributor
There was a problem hiding this comment.
this can be removed from this PR after #549 is merged
| @@ -0,0 +1,53 @@ | |||
| // Copyright 2015 Open Source Robotics Foundation, Inc. | |||
Contributor
There was a problem hiding this comment.
other new files too.
Suggested change
| // Copyright 2015 Open Source Robotics Foundation, Inc. | |
| // Copyright 2024 Open Source Robotics Foundation, Inc. |
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
c01ad03 to
24b1c61
Compare
Contributor
Author
|
Closed in favor of #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the messages added by ros2/rcl_interfaces#162 to the
test_communicationpackagePart of ros2/ros2#1538
Depends on ros2/rosidl#796
Depends on ros2/rosidl_typesupport_fastrtps#116
Depends on ros2/rcl_interfaces#162